netdev - Re: linux-next: Tree for March 27 (netfilter build error)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 29 Mar 2009 13:48:33 +0200
From:	Harald Welte <laforge@...filter.org>
To:	David Miller <davem@...emloft.net>
Cc:	gorcunov@...il.com, randy.dunlap@...cle.com, pablo@...filter.org,
	sfr@...b.auug.org.au, linux-next@...r.kernel.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	kaber@...sh.net, netfilter-devel@...r.kernel.org
Subject: Re: linux-next: Tree for March 27 (netfilter build error)

Hi Dave,

On Sat, Mar 28, 2009 at 11:47:39PM -0700, David Miller wrote:
> From: Cyrill Gorcunov <gorcunov@...il.com>
> Date: Sun, 29 Mar 2009 10:47:04 +0400
> 
> > [Randy Dunlap - Sat, Mar 28, 2009 at 09:26:42PM -0700]
> > ... 
> > | works_for_me.  Thanks.
> > | but missing S-O-B.
> > | 
> > | Acked-by: Randy Dunlap <randy.dunlap@...cle.com>
> > ...
> > 
> > Thanks for testing Randy. So if nobody will complain
> > here is a solid version of the patch. Though I would like
> > if Pablo or Patrick confirm its correctness. Thanks!
> 
> I'll apply this once Patrick or Pablo have a look at it.

I'm neither of them but I strongly believe the patch is correct.   

The only question that Patrick raised during the discussion of this patch some
days ago is whether the __ipv6_addr_type() call would cause a runtime
dependency to thei ipv6 module.  This would be bad since loading the
xt_cluster.ko module should not pull in the IPv6 protocol module.

I have just verified that __ipv6_addr_type is provided by
net/ipv6/addrconf_core.c, which specifically states it contains functions
"needed by static components when full IPv6 support is not configured or
static".   This is confirmed by the makefile, which addes addrconf_core.o to
obj-y.

So from my point of view, I cannot see any problems.

Regards.
-- 
- Harald Welte <laforge@...filter.org>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)