netdev - Re: [PATCH] drivers/net/b44.c: fix regressions in error recovery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090329.134813.151007211.davem@davemloft.net>
Date:	Sun, 29 Mar 2009 13:48:13 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	cjw@...eel.dyndns.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] drivers/net/b44.c: fix regressions in error recovery

From: Christiaan Welvaart <cjw@...eel.dyndns.org>
Date: Sun, 29 Mar 2009 15:25:16 +0200 (CEST)

> hi,
> 
> When I max out a b44 device using NFS and then add http traffic (both inbound), the device resets every few minutes. This causes huge delays due to the PHY reset which was introduced by commit http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=fedb0eefe286a6409aa2c6c6f2353c595e68d33d
> It changes b44_halt() to disable the PHY but this function gets called in 2 error recovery situations and some configuration changes. IMHO disabling the PHY in those cases is a total waste of time. This patch reverts those cases to the old behavior.
> 
> Signed-off-by: Christiaan Welvaart <cjw@...eel.dyndns.org>

Firstly your patch was corrupted by your email client,
lots of whitespace damange at the beginning of lines etc.

And I don't necessarily agree with your change.

If the chip TX times out, we have no idea really what caused
the problem otherwise it wouldn't happen in the first place.
So resetting the PHY is definitely an appropriate course of
action.

You really need to find out why the chip is crapping out in
the first place, and fix that, to get rid of the delays.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html