netdev - Re: [PATCH 6/9] RDS: Fix ordering in a conditional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c0a09e5c0903302356m688fd370k65151f99f43dfdfc@mail.gmail.com>
Date:	Mon, 30 Mar 2009 23:56:14 -0700
From:	Andrew Grover <andy.grover@...il.com>
To:	Roland Dreier <rdreier@...co.com>
Cc:	Andy Grover <andy.grover@...cle.com>, netdev@...r.kernel.org,
	rds-devel@....oracle.com
Subject: Re: [PATCH 6/9] RDS: Fix ordering in a conditional

On Mon, Mar 30, 2009 at 9:27 PM, Roland Dreier <rdreier@...co.com> wrote:
>  > -    if (0 <= ret && (unsigned) ret < nr_pages) {
>  > +    if (ret > 0 && (unsigned) ret < nr_pages) {
>
> This is not an equivalent transformation -- the original code is true if
> ret == 0, while the new code is false.

Ah! Good point.

> Also it seems you don't need the unsigned cast here, since the clause
> before just checked that ret is positive?

True, but I'd bet the compiler will warn if we remove it. I'll try it
tomorrow and see.

Thanks! -- Regards -- Andy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html