[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2a27d3730903310116r4d8602b8y41e466801bbb8d3e@mail.gmail.com>
Date: Tue, 31 Mar 2009 16:16:58 +0800
From: Li Yang <leoli@...escale.com>
To: Scott Wood <scottwood@...escale.com>
Cc: Joakim Tjernlund <Joakim.Tjernlund@...nsmode.se>,
linuxppc-dev@...abs.org, netdev@...r.kernel.org
Subject: Re: [PATCH] ucc_geth: Rework the TX logic.
On Tue, Mar 31, 2009 at 1:22 AM, Scott Wood <scottwood@...escale.com> wrote:
> Joakim Tjernlund wrote:
>>
>> gianfar does not seem to use in_/out_ functions for the BDs. Works just
>> fine that too it seems.
>
> It does now that it has explicit barriers in a few places. Before they were
> added, it would sometimes fail under load. That was due to a compiler
> reordering, but CPU reordering was possible as well.
I noticed that in gianfar these memory access is not protected by
"volatile". Can this be the reason why the compiler did some unwanted
optimization?
- Leo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists