[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090402150908.GA1382@gondor.apana.org.au>
Date: Thu, 2 Apr 2009 23:09:08 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Patrick McHardy <kaber@...sh.net>
Cc: David Miller <davem@...emloft.net>, nhorman@...driver.com,
zbr@...emap.net, netdev@...r.kernel.org, kuznet@....inr.ac.ru,
pekkas@...core.fi, jmorris@...ei.org, yoshfuji@...ux-ipv6.org
Subject: Re: [Patch 4/5] Network Drop Monitor: Adding drop monitor
implementation & Netlink protocol
On Thu, Apr 02, 2009 at 05:06:40PM +0200, Patrick McHardy wrote:
>
> Yes, that should always work. For new stuff I think we should try
> to avoid encapsulating larger structures in single attributes though
> since it forces us to do copy everything, instead of just the types
> that really require it (and the padding issues in case of at least
> non-priviledged interfaces).
Are there any situations where we want to use a struct? Perhaps
we can just ban it altogether for new code?
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists