netdev - Re: [PATCH 1/1] r8169: reset IntrStatus after chip reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090402.010608.05024028.davem@davemloft.net>
Date:	Thu, 02 Apr 2009 01:06:08 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	romieu@...zoreil.com
Cc:	fzu@...gehoertderstaat.de, josep.puigdemont@...il.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] r8169: reset IntrStatus after chip reset

From: Francois Romieu <romieu@...zoreil.com>
Date: Thu, 2 Apr 2009 00:09:41 +0200

> Original comment (Karsten):
> On a MSI MS-6702E mainboard, when in rtl8169_init_one() for the first time
> after BIOS has run, IntrStatus reads 5 after chip has been reset.
> IntrStatus should equal 0 there, so patch changes IntrStatus reset to happen
> after chip reset instead of before.
> 
> Remark (Francois):
> Assuming that the loglevel of the driver is increased above NETIF_MSG_INTR,
> the bug reveals itself with a typical "interrupt 0025 in poll" message
> at startup. In retrospect, the message should had been read as an hint of
> an unexpected hardware state several months ago :o(
> 
> Fixes (at least part of) https://bugzilla.redhat.com/show_bug.cgi?id=460747
> 
> Signed-off-by: Karsten Wiese <fzu@...gehoertderstaat.de>
> Signed-off-by: Francois Romieu <romieu@...zoreil.com>
> Tested-by: Josep <josep.puigdemont@...il.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html