netdev - Re: [PATCH 1/2] net: allow multiple dev per napi with GRO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090402082848.GA29686@gondor.apana.org.au>
Date:	Thu, 2 Apr 2009 16:28:48 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	David Miller <davem@...emloft.net>
Cc:	shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] net: allow multiple dev per napi with GRO

On Thu, Apr 02, 2009 at 01:08:01AM -0700, David Miller wrote:
> From: Stephen Hemminger <shemminger@...tta.com>
> Date: Wed, 1 Apr 2009 14:20:20 -0700
> 
> > GRO assumes that there is a one-to-one relationship between NAPI
> > structure and network device. Some devices like sky2 share multiple
> > devices on a single interrupt so only have one NAPI handler. Rather than
> > split GRO from NAPI, just have GRO assume if device changes that
> > it is a different flow.
> > 
> > Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
> 
> Looks good, applied.

Yep, looks good to me too.  It's only the non-skb interface that
can't handle a shared napi as it uses napi->dev to construct the
skb.

I'm currently experimenting with a new interface to replace the
existing non-skb interface.  The idea is to get the driver to do
what we currently do in napi_fraginfo_skb through helpers.  This
should remove the usage of napi->dev.  It should also remove the
unnecessary double-copying of the frags array.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html