netdev - Re: [Regression in 2.6.29] forcedeth doesn't work after resume from hibernation (was: Re: Resume after hibernation regression in 2.6.29)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9ae48b020904030824o1f94831asb60f979b3e489a8b@mail.gmail.com>
Date:	Fri, 3 Apr 2009 08:24:12 -0700
From:	Ed Swierk <eswierk@...stanetworks.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	"Tvrtko A. Ursulin" <tvrtko@...ulin.net>,
	Pavel Machek <pavel@....cz>,
	linux-pm <linux-pm@...ts.linux-foundation.org>,
	kernel list <linux-kernel@...r.kernel.org>,
	Tobias Diedrich <ranma+kernel@...edrich.de>,
	Ayaz Abdulla <aabdulla@...dia.com>,
	netdev <netdev@...r.kernel.org>,
	Arthur Jones <ajones@...erbed.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [Regression in 2.6.29] forcedeth doesn't work after resume from 
	hibernation (was: Re: Resume after hibernation regression in 2.6.29)

On Fri, Mar 27, 2009 at 1:09 PM, Rafael J. Wysocki <rjw@...k.pl> wrote:
> I was able to reproduce the problem and identify the commit that broke the
> resume of forcedeth, which turned out to be:
>
> commit cb52deba12f27af90a46d2f8667a64888118a888
> Author: Ed Swierk <eswierk@...stra.com>
> Date:   Mon Dec 1 12:24:43 2008 +0000
>
>    forcedeth: power down phy when interface is down
>
>    Signed-off-by: Ed Swierk <eswierk@...stra.com>
>    Tested-by: Arthur Jones <ajones@...erbed.com>
>    Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
>    Signed-off-by: David S. Miller <davem@...emloft.net>
>
> Since I have no slightest idea of what this commit is supposed to achieve,
> I can only ask for reverting it.  It reverts cleanly, BTW.

The change causes forcedeth to bring down the physical link when an
interface goes down; leaving it up causes the switch at the other end
to think the port is still active, with potentially random speed and
duplex parameters.

It's possible that the forcedeth driver needs to reset autonegotiation
after bringing it up the link again.

Can you please try this on a 2.6.29 kernel that's exhibiting the
symptoms you describe, after resuming the machine from hibernation:

  ethtool -s eth1 autoneg off speed 100 duplex full
  ethtool -s eth1 autoneg on

This should reset autonegotiation manually and bring the link. Let me
know how it goes.

Thanks,
--Ed
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html