netdev - Re: [PATCH] Software receive packet steering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090408.161515.40986410.davem@davemloft.net>
Date:	Wed, 08 Apr 2009 16:15:15 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	therbert@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH] Software receive packet steering

From: Stephen Hemminger <shemminger@...tta.com>
Date: Wed, 8 Apr 2009 16:09:48 -0700

> On Wed, 8 Apr 2009 15:48:12 -0700
> Tom Herbert <therbert@...gle.com> wrote:
> 
>> -extern int		netif_receive_skb(struct sk_buff *skb);
>> +extern int            __netif_receive_skb(struct sk_buff *skb);
>> +
>> +static inline int netif_receive_skb(struct sk_buff *skb)
>> +{
>> +#ifdef CONFIG_NET_SOFTRPS
>> +	return netif_rx(skb);
>> +#else
>> +	return __netif_receive_skb(skb);
>> +#endif
>> +}
> 
> Ugh, this forces all devices receiving back into a single backlog
> queue.

Yes, it basically turns off NAPI.

This patch seems to be throwing the baby out with the
bath water.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html