netdev - Re: [E1000-devel] [PATCH] Be explict with what we are !'ing in ixgbe_sfp_config_module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <9929d2390904081926m6176d705y481085318a930087@mail.gmail.com>
Date:	Wed, 8 Apr 2009 19:26:08 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Tony Breeds <tony@...eyournoodle.com>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	e1000-devel@...ts.sourceforge.net
Subject: Re: [E1000-devel] [PATCH] Be explict with what we are !'ing in 
	ixgbe_sfp_config_module_task()

On Tue, Apr 7, 2009 at 9:44 PM, Tony Breeds <tony@...eyournoodle.com> wrote:
> GCC warns:
> drivers/net/ixgbe/ixgbe_main.c: In function 'ixgbe_sfp_config_module_task':
> drivers/net/ixgbe/ixgbe_main.c:3920: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~'
>
> Which I think is right.  Bracket to remove ambiguity.
>
> Signed-off-by: Tony Breeds <tony@...eyournoodle.com>
> ---

Thanks, I will add it to my queue of ixgbe patches.
Remember to CC netdev mailing list for networking patches.

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html