netdev - Re: rds: use kmem_cache_zalloc instead of kmem_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 09 Apr 2009 10:43:13 -0700
From:	Andy Grover <andy.grover@...cle.com>
To:	Wei Yongjun <yjwei@...fujitsu.com>
CC:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: rds: use kmem_cache_zalloc instead of kmem_cache_alloc/memset

Wei Yongjun wrote:
> Use kmem_cache_zalloc instead of kmem_cache_alloc/memset.
> 
> Signed-off-by: Wei Yongjun <yjwei@...fujitsu.com>
> ---
>  net/rds/connection.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/net/rds/connection.c b/net/rds/connection.c
> index 273f064..d14445c 100644
> --- a/net/rds/connection.c
> +++ b/net/rds/connection.c
> @@ -148,14 +148,12 @@ static struct rds_connection *__rds_conn_create(__be32 laddr, __be32 faddr,
>  	if (conn)
>  		goto out;
>  
> -	conn = kmem_cache_alloc(rds_conn_slab, gfp);
> +	conn = kmem_cache_zalloc(rds_conn_slab, gfp);
>  	if (conn == NULL) {
>  		conn = ERR_PTR(-ENOMEM);
>  		goto out;
>  	}
>  
> -	memset(conn, 0, sizeof(*conn));
> -
>  	INIT_HLIST_NODE(&conn->c_hash_node);
>  	conn->c_version = RDS_PROTOCOL_3_0;
>  	conn->c_laddr = laddr;

Thanks, will include in next rds updates!

Regards -- Andy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html