netdev - Re: [Bugme-new] [Bug 13004] New: [bonding] xmit hash policy doesn't recognize vlan tagged and PPPoE frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20090409141000.d0ae7fcb.akpm@linux-foundation.org>
Date:	Thu, 9 Apr 2009 14:10:00 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	netdev@...r.kernel.org
Cc:	bugme-daemon@...zilla.kernel.org, Jay Vosburgh <fubar@...ibm.com>,
	bonding-devel@...ts.sourceforge.net, adwol@...k.pl
Subject: Re: [Bugme-new] [Bug 13004] New: [bonding] xmit hash policy doesn't
 recognize vlan tagged and PPPoE frames


(switched to email.  Please respond via emailed reply-to-all, not via the
bugzilla web interface).

On Fri, 3 Apr 2009 16:34:24 GMT
bugzilla-daemon@...zilla.kernel.org wrote:

> http://bugzilla.kernel.org/show_bug.cgi?id=13004
> 
>            Summary: [bonding] xmit hash policy doesn't recognize vlan
>                     tagged and PPPoE frames
>            Product: Networking
>            Version: 2.5
>           Platform: All
>         OS/Version: Linux
>               Tree: Mainline
>             Status: NEW
>           Severity: normal
>           Priority: P1
>          Component: Other
>         AssignedTo: acme@...stprotocols.net
>         ReportedBy: adwol@...k.pl
>         Regression: No
> 
> 
> Hi,
> 
> there is a problem with xmit hash policy in bonding driver. It doesn't work
> when using layer 2+3 or 3+4 policy on vlan tagged or PPPoE frames.
> Functions bond_xmit_hash_policy_l23() and bond_xmit_hash_policy_l34()
> check if frame ethertype is ETH_P_IP and unless, it fall back to layer 2
> hashing. It additionally should check, if frame ethertype is ETH_P_8021Q or
> ETH_P_PPP_SES and embedded type is ETH_P_IP and if so, also treat it as
> IP packet.
> 
> Appropriate patch in attachment.
> 

Jay, there's a patch in there.

Adam, please prefer to submit patches via email as per
Documentation/SubmittingPatches rather than via bugzilla, thanks.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html