netdev - Re: [PATCH] Bonding: fix zero address hole bug in arp_ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090411.025650.40194406.davem@davemloft.net>
Date:	Sat, 11 Apr 2009 02:56:50 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	fubar@...ibm.com
Cc:	brian.haley@...com, steve@...utenetworks.com,
	netdev@...r.kernel.org, bonding-devel@...ts.sourceforge.net,
	akpm@...ux-foundation.org
Subject: Re: [PATCH] Bonding: fix zero address hole bug in arp_ip_target
 list

From: Jay Vosburgh <fubar@...ibm.com>
Date: Fri, 10 Apr 2009 23:51:19 -0700

> Brian Haley <brian.haley@...com> wrote:
> 
>>Fix a zero address hole bug in the bonding arp_ip_target list
>>that was causing the bond to ignore ARP replies (bugz 13006).
>>Instead of just setting the array entry to zero, we now
>>copy any additional entries down one slot, putting the
>>zero entry at the end.  With this change we can now have
>>all the loops that walk the array stop when they hit a zero
>>since there will be no addresses after it.
>>
>>Signed-off-by: Brian Haley <brian.haley@...com>
> 
> 	This all looks reasonable to me.  This patch appears to be an
> extension of some code (not as a patch) provided in bugzilla 13006 by
> Steve Howard <steve@...utenetworks.com>, so I suspect he should sign off
> on this as well, or at the very least be credited in the log; I'd write
> that as:
> 
> 	Changes are based in part on code fragment provided in kernel
> bugzilla 13006 by Steve Howard <steve@...utenetworks.com>.
> 
> 	This can go to -stable, too.
> 
> 	-J
> 
> Signed-off-by: Jay Vosburgh <fubar@...ibm.com>

Indeed, please fix up the attribution and I will apply this and
queue up for -stable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html