netdev - Re: [PATCH 2/3] phylib: Allow early-out in phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090413.145210.265793440.davem@davemloft.net>
Date:	Mon, 13 Apr 2009 14:52:10 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	agust@...x.de
Cc:	netdev@...r.kernel.org, afleming@...escale.com
Subject: Re: [PATCH 2/3] phylib: Allow early-out in phy_change

From: Anatolij Gustschin <agust@...x.de>
Date: Tue,  7 Apr 2009 14:01:42 +0200

> Marvell 88E1121R Dual PHY device can be hardware-configured
> to use shared interrupt pin for both PHY ports. For such
> PHY configurations using shared PHY interrupt phy_interrupt()
> handler will also schedule a work for PHY port which didn't
> cause an interrupt.
> 
> This patch adds a possibility for PHY drivers to provide
> did_interrupt() function which reports if the PHY (or a PHY
> port in a multi-PHY device) generated an interrupt. This
> function is called in phy_change() as phy_change() shouldn't
> proceed if it is invoked for a PHY which didn't cause an
> interrupt. So check for interrupt originator in phy_change()
> to allow early-out.
> 
> Signed-off-by: Anatolij Gustschin <agust@...x.de>

Applied.

> +	 * For multy-PHY devices with shared PHY interrupt pin
               ^^^^^

I fixed that typo when commiting this change.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html