netdev - Re: initial congestion window for connections in the listen queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090413.145829.97306950.davem@davemloft.net>
Date:	Mon, 13 Apr 2009 14:58:29 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ilpo.jarvinen@...sinki.fi
Cc:	opurdila@...acom.com, netdev@...r.kernel.org
Subject: Re: initial congestion window for connections in the listen queue

From: "Ilpo Järvinen" <ilpo.jarvinen@...sinki.fi>
Date: Tue, 14 Apr 2009 00:54:40 +0300 (EEST)

> A long-standing feature in tcp_init_metrics() is such that any of its goto 
> reset prevents call to tcp_init_cwnd(). I never remembered to fix that.

Grumble, we definitely need to fix that!

I suspect I added that problem, because tcp_init_metrics() at one
point couldn't cope with a NULL dst.  But that is no longer the
case so I'm pretty sure we can unconditionally go:

	tp->snd_cwnd = tcp_init_cwnd(tp, dst);
	tp->snd_cwnd_stamp = tcp_time_stamp;

in the 'reset' path too, right?

But note thata even if this reset path is taken, we should still have
at least the default ->snd_cwnd value of 2.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html