netdev - Re: [PATCH v2] Bonding: fix zero address hole bug in arp_ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 13 Apr 2009 00:12:01 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	akpm@...ux-foundation.org
Cc:	brian.haley@...com, fubar@...ibm.com, steve@...utenetworks.com,
	netdev@...r.kernel.org, bonding-devel@...ts.sourceforge.net
Subject: Re: [PATCH v2] Bonding: fix zero address hole bug in arp_ip_target
 list

From: Andrew Morton <akpm@...ux-foundation.org>
Date: Sat, 11 Apr 2009 11:52:25 -0700

> On Sat, 11 Apr 2009 11:20:02 -0400 Brian Haley <brian.haley@...com> wrote:
> 
>> Fix a zero address hole bug in the bonding arp_ip_target list
>> that was causing the bond to ignore ARP replies (bugz 13006).
>> Instead of just setting the array entry to zero, we now
>> copy any additional entries down one slot, putting the
>> zero entry at the end.  With this change we can now have
>> all the loops that walk the array stop when they hit a zero
>> since there will be no addresses after it.
>> 
>> Changes are based in part on code fragment provided in kernel
>> bugzilla 13006 by Steve Howard <steve@...utenetworks.com>
>> 
> 
> This isn't written down anywhere, but...
> 
> If the patch addresses a bugzilla report, please quote the full
> bugzilla URL in the changelog.  ie:
> http://bugzilla.kernel.org/show_bug.cgi?id=13006

I've fixed this when checking in Brian's patch, and also
queued it up for -stable.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html