netdev - Re: [PATCH]ipv6:remove useless check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090414.022227.88248944.davem@davemloft.net>
Date:	Tue, 14 Apr 2009 02:22:27 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	shanwei@...fujitsu.com
Cc:	yanghy@...fujitsu.com, netdev@...r.kernel.org, brian.haley@...com
Subject: Re: [PATCH]ipv6:remove useless check

From: Shan Wei <shanwei@...fujitsu.com>
Date: Tue, 14 Apr 2009 11:31:40 +0800

> Yang Hongyang said:
>> After switch (rthdr->type) {...},the check below is completely useless.Because:
>> if the type is 2,then hdrlen must be 2 and segments_left must be 1,clearly the
>> check is redundant;if the type is not 2,then goto sticky_done,the check is useless
>> too.
>> 
> 
> Add CC  Brian Haley.
> 
> The check is defined only for Type 0 Routing header in section 4.4 of RFC2460: 
> 
>    Hdr Ext Len          8-bit unsigned integer.  Length of the Routing
>                         header in 8-octet units, not including the first
>                         8 octets.  For the Type 0 Routing header, Hdr
>                         Ext Len is equal to two times the number of
>                         addresses in the header.
> 
> Now, Type 0 Routing header has been removed, the check is redundant.
> 
> Reviewed-by: Shan Wei <shanwei@...fujitsu.com>
> 
>> Signed-off-by: Yang Hongyang <yanghy@...fujitsu.com>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html