netdev - Re: [PATCH] phylib: Fix delay argument of schedule_delayed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 15 Apr 2009 20:37:19 +0200
From:	Marcin Slusarz <marcin.slusarz@...il.com>
To:	Atsushi Nemoto <anemo@....ocn.ne.jp>
CC:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] phylib: Fix delay argument of schedule_delayed_work

Atsushi Nemoto wrote:
> The commit a390d1f3 ("phylib: convert state_queue work to
> delayed_work") missed converting 'expires' value to 'delay' value.

Yeah, sorry about that.

> 
> Signed-off-by: Atsushi Nemoto <anemo@....ocn.ne.jp>

Acked-by: Marcin Slusarz <marcin.slusarz@...il.com>

> ---
>  drivers/net/phy/phy.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> index 3ff1f42..5737b85 100644
> --- a/drivers/net/phy/phy.c
> +++ b/drivers/net/phy/phy.c
> @@ -434,7 +434,7 @@ void phy_start_machine(struct phy_device *phydev,
>  	phydev->adjust_state = handler;
>  
>  	INIT_DELAYED_WORK(&phydev->state_queue, phy_state_machine);
> -	schedule_delayed_work(&phydev->state_queue, jiffies + HZ);
> +	schedule_delayed_work(&phydev->state_queue, HZ);
>  }
>  
>  /**
> @@ -937,6 +937,5 @@ static void phy_state_machine(struct work_struct *work)
>  	if (err < 0)
>  		phy_error(phydev);
>  
> -	schedule_delayed_work(&phydev->state_queue,
> -				jiffies + PHY_STATE_TIME * HZ);
> +	schedule_delayed_work(&phydev->state_queue, PHY_STATE_TIME * HZ);
>  }

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html