netdev - Re: [net-2.6 PATCH 1/2] ixgbe: fix tx queue index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090414.215415.77558705.davem@davemloft.net>
Date:	Tue, 14 Apr 2009 21:54:15 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, gospo@...hat.com, fengguang.wu@...el.com
Subject: Re: [net-2.6 PATCH 1/2] ixgbe: fix tx queue index

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Tue, 14 Apr 2009 20:51:58 -0700

> Don't do the num_tx_queues based masking on calculating tx queue
> index.
> 
>  1) num_tx_queues is not always power-of-2, because it also depends on
>     the online cpu numbers. So the masking could be a performance bug
>     on a 6 cpu system.
>  2) queue_mapping will be limited by real_num_tx_queues=num_tx_queues
>     in the generic netdev function set_cur_queue_map(). So the bound
>     limiting here is not necessary.
> 
> Signed-off-by: Wu Fengguang <fengguang.wu@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html