netdev - Re: [PATCH] myr10ge: again fix lro_gen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49E5AD56.6020701@myri.com>
Date:	Wed, 15 Apr 2009 11:48:06 +0200
From:	Brice Goglin <brice@...i.com>
To:	David Miller <davem@...emloft.net>
CC:	sgruszka@...hat.com, netdev@...r.kernel.org, gallatin@...i.com,
	brice@...i.com
Subject: Re: [PATCH] myr10ge: again fix lro_gen_skb() alignment

David Miller wrote:
> From: Stanislaw Gruszka <sgruszka@...hat.com>
> Date: Wed, 15 Apr 2009 10:09:37 +0200
>
>   
>> Add LRO alignment initially committed in 621544eb8c3beaa859c75850f816dd9b056a00a3
>> and removed in 0dcffac1a329be69bab0ac604bf7283737108e68 during conversion to
>> multi-slice.
>>
>> Signed-off-by: Stanislaw Gruszka <sgruszka@...hat.com>
>>     
>
> Applied, thanks.
>
> Please, in the future, add the header string of the commit message
> when referencing GIT commits.  When this patch is added to the -stable
> kernel or similar the GIT commit ideas might be different and it
> will be impossible for someone reading your commit message to find
> the referenced commit using only the SHA ID.
>   

I guess we need to send this patch to the stable maintainers since it
should affect 2.6.27, .28 and .29.

> Also, it would great to get this driver converted over to GRO,
> such bugs like this one aren't even possible with GRO :-)
>   

It looks like nobody complains about GRO bugs or performance-problems
anymore so we might indeed look at converting myri10ge for 2.6.31.

Is there a good summary somewhere of why GRO is better, and how to
actually convert drivers?

Brice

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html