netdev - Re: [PATCH -next] sfc: Use correct macro to set event bitfield

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090414.194856.169034323.davem@davemloft.net>
Date:	Tue, 14 Apr 2009 19:48:56 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	netdev@...r.kernel.org, linux-net-drivers@...arflare.com
Subject: Re: [PATCH -next] sfc: Use correct macro to set event bitfield

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Wed, 15 Apr 2009 02:29:52 +0100

> falcon_sim_phy_event() used EFX_OWORD_FIELD, which operates on
> bitfields in 128-bit values, on an event, which is a 64-bit value.
> This should be harmless - these macros always use little-endian
> ordering, so it would read and write back the following 8 bytes
> unchanged - but it is obviously wrong.
> 
> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>

Applied.  And, I think this qualifies for net-2.6 so that's
where I put it.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html