netdev - Re: [PATCH] macb: Add support of the netpoll API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090416110753.5c75b805@hskinnemoen-d830>
Date:	Thu, 16 Apr 2009 11:07:53 +0200
From:	Haavard Skinnemoen <haavard.skinnemoen@...el.com>
To:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
Cc:	netdev@...r.kernel.org,
	Michael Opdenacker <michael@...e-electrons.com>
Subject: Re: [PATCH] macb: Add support of the netpoll API

Thomas Petazzoni wrote:
> macb: Add support of the netpoll API
> 
> With this patch in place, I'm successfully able to use the netconsole
> mechanism with the Calao USB-A9263 board, which uses the AT91SAM9263
> CPU, which in terms of Ethernet controller is supported by the macb
> driver.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
> ---
>  drivers/net/macb.c |   16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> Index: linux/drivers/net/macb.c
> ===================================================================
> --- linux.orig/drivers/net/macb.c
> +++ linux/drivers/net/macb.c
> @@ -616,6 +616,19 @@
>  	return IRQ_HANDLED;
>  }
>  
> +#ifdef CONFIG_NET_POLL_CONTROLLER
> +/*
> + * Polling receive - used by netconsole and other diagnostic tools
> + * to allow network i/o with interrupts disabled.
> + */
> +static void macb_poll_controller(struct net_device *dev)
> +{
> +	disable_irq(dev->irq);

Hmm...is this safe? What if printk() is called from the macb interrupt
handler?

Haavard
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html