netdev - [PATCH 1/3] ipconfig: use same time units for CONF_{PRE,POST}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Apr 2009 13:37:37 +0400
From:	dmitry.krivoschekov@...il.com
To:	netdev@...r.kernel.org, davem@...emloft.net
Cc:	Dmitry Krivoschekov <dkrivoschekov@...mvista.com>
Subject: [PATCH 1/3] ipconfig: use same time units for CONF_{PRE,POST}_OPEN delays

From: Dmitry Krivoschekov <dkrivoschekov@...mvista.com>

It's confusing that the delay before opening is measured in msecs
while after opening the delay is in seconds. Lets use the same
time units for both.

Signed-off-by: Dmitry Krivoschekov <dkrivoschekov@...mvista.com>
---
 net/ipv4/ipconfig.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
index da134aa..4c6e38f 100644
--- a/net/ipv4/ipconfig.c
+++ b/net/ipv4/ipconfig.c
@@ -87,7 +87,7 @@
 
 /* Define the friendly delay before and after opening net devices */
 #define CONF_PRE_OPEN		500	/* Before opening: 1/2 second */
-#define CONF_POST_OPEN		1	/* After opening: 1 second */
+#define CONF_POST_OPEN		1000	/* After opening: 1 second */
 
 /* Define the timeout for waiting for a DHCP/BOOTP/RARP reply */
 #define CONF_OPEN_RETRIES 	2	/* (Re)open devices twice */
@@ -1291,7 +1291,7 @@ static int __init ip_auto_config(void)
 		return -1;
 
 	/* Give drivers a chance to settle */
-	ssleep(CONF_POST_OPEN);
+	msleep(CONF_POST_OPEN);
 
 	/*
 	 * If the config information is insufficient (e.g., our IP address or
-- 
1.6.1.2.MVISTA.5.ga9f3b

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html