netdev - Re: [PATCH] net: Fix GRO for multiple page fragments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1239976872.5297.15.camel@deadeye.i.decadent.org.uk>
Date:	Fri, 17 Apr 2009 15:01:12 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, herbert@...dor.apana.org.au
Subject: Re: [PATCH] net: Fix GRO for multiple page fragments

On Fri, 2009-04-17 at 01:27 -0700, David Miller wrote:
> From: Ben Hutchings <bhutchings@...arflare.com>
> Date: Thu, 16 Apr 2009 19:04:20 +0100
> 
> > This loop over fragments in napi_fraginfo_skb() was "interesting".
> > 
> > Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>
> > ---
> > This is not tested, as only cxgb3 will currently pass in multiple
> > fragments at the same time.  skb_shinfo(skb)->nr_frags would already be
> > 0 but it makes no sense to rely on that.  I hope I'm not missing some
> > subtlety...
> 
> I think the code still isn't right after your changes.
> 
> The intent seems to be to append frags from 'info' into the SKB,
> so that it works even if the SKB already has some frags.
[...]

This function is setting up a 'new' skb from the fragments it's given.
To avoid allocation overhead it recycles skbs via napi->skb if they are
merged (or otherwise discarded).  There should be no data attached to
the recycled skb.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html