netdev - Re: [PATCH 2/2] macb: process the RX ring regardless of interrupt status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090417.013107.41038229.davem@davemloft.net>
Date:	Fri, 17 Apr 2009 01:31:07 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	haavard.skinnemoen@...el.com
Cc:	netdev@...r.kernel.org, nicolas.ferre@...el.com,
	erik.waling@...ftel.com
Subject: Re: [PATCH 2/2] macb: process the RX ring regardless of interrupt
 status

From: Haavard Skinnemoen <haavard.skinnemoen@...el.com>
Date: Thu, 16 Apr 2009 11:32:11 +0200

> Suppose that we receive lots of frames, start processing them, but
> exhaust our budget so that we return before we had a chance to look
> at all of them.
> 
> Then, when the network layer calls us again, we will only continue
> processing the buffers if the REC bit was set in the mean time, which it
> might not be if there was a brief pause in the flow of packets. If this
> happens, we'll simply display a warning and call netif_rx_complete()
> with potentially lots of unprocessed packets in the RX ring...
> 
> Fix this by scanning the ring no matter what flags are set in the
> interrupt status register.
> 
> Signed-off-by: Erik Waling <erik.waling@...ftel.com>
> Signed-off-by: Haavard Skinnemoen <haavard.skinnemoen@...el.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html