lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 17 Apr 2009 01:59:14 -0700 (PDT) From: David Miller <davem@...emloft.net> To: dada1@...mosbay.com Cc: netdev@...r.kernel.org Subject: Re: [PATCH] loopback: packet drops accounting From: Eric Dumazet <dada1@...mosbay.com> Date: Fri, 17 Apr 2009 10:56:57 +0200 > We can in some situations drop packets in netif_rx() > > loopback driver does not report these (unlikely) drops to its stats, > and incorrectly change packets/bytes counts. > > After this patch applied, "ifconfig lo" can reports these drops as in : > > # ifconfig lo > lo Link encap:Local Loopback > inet addr:127.0.0.1 Mask:255.0.0.0 > UP LOOPBACK RUNNING MTU:16436 Metric:1 > RX packets:692562900 errors:0 dropped:0 overruns:0 frame:0 > TX packets:692562900 errors:3228 dropped:3228 overruns:0 carrier:0 > collisions:0 txqueuelen:0 > RX bytes:2865674174 (2.6 GiB) TX bytes:2865674174 (2.6 GiB) > > I chose to reflect those errors only in tx_dropped/tx_errors, and not mirror > these errors in rx_dropped/rx_errors. > > Signed-off-by: Eric Dumazet <dada1@...mosbay.com> Well, logically the receive is what failed, not the transmit. I think it's therefore misleading to count it as a TX drop. Do you feel strongly about this? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists