netdev - Re: [PATCH] macb: Add support of the netpoll API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090417.034416.110856368.davem@davemloft.net>
Date:	Fri, 17 Apr 2009 03:44:16 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	haavard.skinnemoen@...el.com
Cc:	thomas.petazzoni@...e-electrons.com, netdev@...r.kernel.org,
	michael@...e-electrons.com
Subject: Re: [PATCH] macb: Add support of the netpoll API

From: Haavard Skinnemoen <haavard.skinnemoen@...el.com>
Date: Fri, 17 Apr 2009 11:50:11 +0200

> David Miller wrote:
>> From: Haavard Skinnemoen <haavard.skinnemoen@...el.com>
>> Date: Fri, 17 Apr 2009 11:25:53 +0200
>> 
>> > I guess you're right -- we just have to be careful about calling
>> > printk() from within the driver. But it seems a lot easier to just drop
>> > the lock before dumping an error message than it is to work around that
>> > disable_irq() deadlock. And if you're running with verbose debugging
>> > enabled, you probably shouldn't be using netconsole anyway.  
>> 
>> Therefore, do you agree to add Thomas's patch as-is?
> 
> No, therefore, I'd prefer local_irq_save() :-)

I'm pretty sure there is a specific reason driver's use
disable_irq() rather than disabling local cpu IRQs.

I just can't remember it at the moment.

And there absolutely must be a reason, because disable_irq()
is a lot more expensive.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html