netdev - Re: [PATCH] syncookies: remove last_synq_overflow from struct tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090420.022613.84087091.davem@davemloft.net>
Date:	Mon, 20 Apr 2009 02:26:13 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	fw@...len.de
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] syncookies: remove last_synq_overflow from struct
 tcp_sock

From: Florian Westphal <fw@...len.de>
Date: Sun, 19 Apr 2009 21:43:48 +0200

> last_synq_overflow eats 4 or 8 bytes in struct tcp_sock, even
> though it is only used when a listening sockets syn queue
> is full.
> 
> We can (ab)use rx_opt.ts_recent_stamp to store the same information;
> it is not used otherwise as long as a socket is in listen state.
> 
> Move linger2 around to avoid splitting struct mtu_probe
> across cacheline boundary on 32 bit arches.
> 
> Signed-off-by: Florian Westphal <fw@...len.de>

This looks good, applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html