netdev - Re: [net-next-2.6 PATCH 1/5] ixgbe: fix link down initial state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9929d2390904200215q37e04394w4d8878cc1af9a6b@mail.gmail.com>
Date:	Mon, 20 Apr 2009 02:15:04 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, gospo@...hat.com,
	jesse.brandeburg@...el.com
Subject: Re: [net-next-2.6 PATCH 1/5] ixgbe: fix link down initial state

On Mon, Apr 20, 2009 at 2:04 AM, David Miller <davem@...emloft.net> wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Date: Fri, 17 Apr 2009 23:44:27 -0700
>
>> All the intel wired ethernet drivers were calling netif_carrier_off
>> and netif_stop_queue (or variants) before calling register_netdevice
>>
>> This is incorrect behavior as was pointed out by davem, and causes
>> ifconfig and friends to report a strange state before first link
>> after the driver was loaded, since without a netif_carrier_off, the stack
>> assumes carrier_on, but before register_netdev, netlink messages are not
>> sent out telling link state.
>
> All 5 patches applied, thanks!
>
> FWIW, this is definitely a case where I would have found it just as
> appropriate to post one single patch for this.  But that's just me :-)
> --

Good to know, that was discussed, but we thought it would be better
for git logging to have separate patches.

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html