netdev - Re: [PATCH] mlx4_en: Fix cleanup if workqueue create in mlx4_en

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090421.015018.163997666.davem@davemloft.net>
Date:	Tue, 21 Apr 2009 01:50:18 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	rdreier@...co.com
Cc:	yevgenyp@...lanox.co.il, netdev@...r.kernel.org,
	tziporet@...lanox.co.il
Subject: Re: [PATCH] mlx4_en: Fix cleanup if workqueue create in
 mlx4_en_add() fails

From: Roland Dreier <rdreier@...co.com>
Date: Mon, 20 Apr 2009 21:32:08 -0700

> If creating a workqueue fails, don't jump to the error path where that
> same workqueue is destroyed, since destroy_workqueue() can't handle a
> NULL pointer.
> 
> This was spotted by the Coverity checker (CID 2617).
> 
> Signed-off-by: Roland Dreier <rolandd@...co.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html