| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20090421135627.GA1945@ioremap.net> Date: Tue, 21 Apr 2009 17:56:27 +0400 From: Evgeniy Polyakov <zbr@...emap.net> To: Johann Baudy <johann.baudy@...-log.net> Cc: Herbert Xu <herbert@...dor.apana.org.au>, netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Patrick McHardy <kaber@...sh.net>, jamal <hadi@...erus.ca> Subject: Re: [PATCH] TX_RING and packet mmap On Tue, Apr 21, 2009 at 03:16:49PM +0200, Johann Baudy (johann.baudy@...-log.net) wrote: > Yes but in this case, it will be called twice, as shared info (that > contains destructor) is memcopied to new expanded head. > shared info destructor will be excuted two times on "same" data > (during skb_expand_head() and during kfree_skb()) > Actually, I want to know if this behavior is intended with a new > shared info destructor. It depends on your task... You can always store a pointer in the tree/hash and check it in the destructor, you can play some games in the expand helper not to call destructor: like messing with the reference counter and reusing the old area, or silently freeing old area without destruction invocation (presumably with some new helper). Moreover you can allocate skb so that no matter what but it could not be reused by the underlying layers, so it could be fully copied. In this case usual destructor is enough. -- Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists