netdev - Re: [PATCH] pasemi_mac: mac_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090423195403.GA4785@lixom.net>
Date:	Thu, 23 Apr 2009 14:54:03 -0500
From:	Olof Johansson <olof@...om.net>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	netdev@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] pasemi_mac: mac_to_intf() error not noticed

On Thu, Apr 23, 2009 at 08:53:20PM +0200, Roel Kluin wrote:
> Olof Johansson wrote:
> > On Thu, Apr 23, 2009 at 07:44:09PM +0200, Roel Kluin wrote:
> > This can in practice never happen which is likely why it went
> > unnoticed.
> 
> > define a new variable with an appropriate name, please.
> 
> Ok, how's this?

Good, but you might have to repost without the email trail above the
patch description. Normally putting it under the signed-off-by line
with three dashes between will make sure it doesn't get picked up by
the git tools.


Anyway, that's all up to Dave, if you end up reposting feel free to add:

> --------------------------->8-------------8<------------------------------
> mac_to_intf() can return -1 when no device or function is found, but when
> mac->dma_if is unsigned. The error wasn't noticed.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>

Acked-by: Olof Johansson <olof@...om.net>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html