netdev - RE: [PATCH] vxge: fix possible NULL dereference in vxge-traffic.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <78C9135A3D2ECE4B8162EBDCE82CAD7705313EDE@nekter>
Date:	Thu, 23 Apr 2009 22:46:30 -0400
From:	"Ramkrishna Vepa" <Ramkrishna.Vepa@...erion.com>
To:	"Alexander Beregalov" <a.beregalov@...il.com>,
	<netdev@...r.kernel.org>, "David Miller" <davem@...emloft.net>
Subject: RE: [PATCH] vxge: fix possible NULL dereference in vxge-traffic.c

Good catch! This patch looks good.

Thanks,
Ram
> -----Original Message-----
> From: Alexander Beregalov [mailto:a.beregalov@...il.com]
> Sent: Thursday, April 23, 2009 6:32 PM
> To: Ramkrishna Vepa; netdev@...r.kernel.org
> Cc: Alexander Beregalov
> Subject: [PATCH] vxge: fix possible NULL dereference in vxge-traffic.c
> 
> If vpath is NULL then hldev is NULL also.
> 
> Signed-off-by: Alexander Beregalov <a.beregalov@...il.com>
> ---
>  drivers/net/vxge/vxge-traffic.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/vxge/vxge-traffic.c b/drivers/net/vxge/vxge-
> traffic.c
> index 7be0ae1..506625b 100644
> --- a/drivers/net/vxge/vxge-traffic.c
> +++ b/drivers/net/vxge/vxge-traffic.c
> @@ -1923,7 +1923,7 @@ enum vxge_hw_status
__vxge_hw_vpath_alarm_process(
>  	if (vpath == NULL) {
>  		alarm_event = VXGE_HW_SET_LEVEL(VXGE_HW_EVENT_UNKNOWN,
>  			alarm_event);
> -		goto out;
> +		goto out2;
>  	}
> 
>  	hldev = vpath->hldev;
> @@ -2161,7 +2161,7 @@ enum vxge_hw_status
__vxge_hw_vpath_alarm_process(
>  	}
>  out:
>  	hldev->stats.sw_dev_err_stats.vpath_alarms++;
> -
> +out2:
>  	if ((alarm_event == VXGE_HW_EVENT_ALARM_CLEARED) ||
>  		(alarm_event == VXGE_HW_EVENT_UNKNOWN))
>  		return VXGE_HW_OK;
> --
> 1.6.2.3

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html