netdev - Re: [PATCH 0/3] tun: fix aio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 27 Apr 2009 12:34:55 +0300
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	Herbert Xu <herbert@...dor.apana.org.au>, davem@...emloft.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH 0/3] tun: fix aio

On Mon, Apr 27, 2009 at 10:48:37AM +0930, Rusty Russell wrote:
> On Mon, 20 Apr 2009 09:51:38 pm Michael S. Tsirkin wrote:
> > On Mon, Apr 20, 2009 at 08:09:30PM +0800, Herbert Xu wrote:
> > > Michael S. Tsirkin <mst@...hat.com> wrote:
> > > >
> > > > Note: I started out just allocating and copying the iovec rather than adding
> > > > yet another skb-iterating routine, but this turned out to add small but
> > > > measurable overhead on data path: tx time per packet jumped from 6500 to 6700 ns
> > > > (let me know if you want to see that version of the patch).
> > > 
> > > Can you please post the copying version as well so we can compare?
> > 
> > Sure. Here it is: much smaller, but slightly slower.
> 
> Which could probably be fixed by using an on-stack version for a iovec
> of less than a certain size...

I agree that for large message sizes the malloc would probably be
dwarfed by the cost of memory copy. However a large iovec might pass a
small message, might it not?

-- 
MST
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html