netdev - Re: [PATCH] gianfar: irq_of_parse_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090427.031116.43598009.davem@davemloft.net>
Date:	Mon, 27 Apr 2009 03:11:16 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	roel.kluin@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] gianfar: irq_of_parse_and_map() error unnoticed

From: Roel Kluin <roel.kluin@...il.com>
Date: Thu, 23 Apr 2009 14:52:44 +0200

> Not sure which irq_of_parse_and_map() is used, but I found definitions here:
> 
> vi arch/microblaze/kernel/irq.c +23
> vi arch/powerpc/kernel/irq.c +727
> vi arch/sparc/kernel/of_device_32.c +33
> vi arch/sparc/kernel/of_device_64.c +59
> 
> They either return 0 or NO_IRQ - either defined 0, -1, 255 or INT_MAX.
> ------------------------------>8-------------8<---------------------------------
> priv->interruptTransmit, -Receive and -Error are unsigned, so the error path
> wasn't taken when irq_of_parse_and_map() returned an incorrect irq.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com> 

This test is way too convoluted for my taste.

I would rather that the implementations of this interface
use a consistent value for errors.  Preferrably NO_IRQ.

Not applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html