netdev - Re: [PATCH] forcedeth: tx timeout fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090427115945.d736ac1f.akpm@linux-foundation.org>
Date:	Mon, 27 Apr 2009 11:59:45 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Ayaz Abdulla <aabdulla@...dia.com>
Cc:	jgarzik@...ox.com, manfred@...orfullife.com, davem@...emloft.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH] forcedeth: tx timeout fix

On Sat, 25 Apr 2009 15:17:56 -0400
Ayaz Abdulla <aabdulla@...dia.com> wrote:

> This patch fixes the tx_timeout() to properly handle the clean up of the 
> tx ring. It also sets the tx put pointer back to the correct position to 
> be in sync with HW.

It's unclear (to me) what the real-world impact of this bugfix is. 
There isn't enough information here to decide whether the fix should be
backported to 2.6.29 (and earlier?).  What is the user-visible
behaviour change?  What hardware does it affect?  What is the risk that
the change will inadvertently break other setups?  etc.

Please always provide such information in the changelogs.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html