netdev - Re: [net-next PATCH 1/3] ixgbe: enable HW RSC for 82599

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090428.015535.42660210.davem@davemloft.net>
Date:	Tue, 28 Apr 2009 01:55:35 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, gospo@...hat.com,
	alexander.h.duyck@...el.com
Subject: Re: [net-next PATCH 1/3] ixgbe: enable HW RSC for 82599

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Tue, 28 Apr 2009 01:42:37 -0700

> From: Alexander Duyck <alexander.h.duyck@...el.com>
> 
> This patch enables hardware receive side coalescing for 82599 hardware.
> 82599 can merge multiple frames from the same TCP/IP flow into a single
> structure that can span one ore more descriptors.  The accumulated data is
> arranged similar to how jumbo frames are arranged with the exception that
> other packets can be interlaced inbetween.  To overcome this issue a next
> pointer is included in the written back descriptor which indicates the next
> descriptor in the writeback sequence.
> 
> This feature sets the NETIF_F_LRO flag and clearing it via the ethtool set
> flags operation will also disable hardware RSC.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Applied, but.........

Since IXGBE has been converted to GRO, all of this fiddling with
LRO is a complete NOP.  All of that code can be removed completely.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html