netdev - Re: [PATCH] netdev: storage address support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090428.021249.247190041.davem@davemloft.net>
Date:	Tue, 28 Apr 2009 02:12:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jpirko@...hat.com
Cc:	christopher.leech@...el.com, jeffrey.t.kirsher@...el.com,
	netdev@...r.kernel.org, gospo@...hat.com,
	linux-scsi@...r.kernel.org
Subject: Re: [PATCH] netdev: storage address support

From: Jiri Pirko <jpirko@...hat.com>
Date: Tue, 28 Apr 2009 10:30:48 +0200

> Tue, Apr 28, 2009 at 03:48:54AM CEST, davem@...emloft.net wrote:
>>From: Chris Leech <christopher.leech@...el.com>
>>Date: Mon, 27 Apr 2009 15:28:00 -0700
>>
>>> Ignoring the issue of intended use for the moment, if an ethernet driver
>>> wanted to advertise several MAC addresses to the system how should it go
>>> about that?
>>
>>Now that's a more interesting question.
>>
>>It seems better to formalize this.   It can be an ethtool
>>callback or whatever, but what it should do is return
>>an array of addresses, types, and perhaps even indexes
>>with types.
> 
> Well the list of device addresses from my patch can pretty much solve this.
> There can be additional field in struct netdev_hw_addr to store flags to
> identify the mac address type (like primary, lan, san, slave, etc).
> 
> I think it would be better to do this in general (in struct net_device) then
> inside each driver exported by ethtool or whatever.

Agreed, can you update your patch to provide such a 'type' tag?

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html