netdev - [PATCH net-next] ixgbe: removing unnecesary assignments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 29 Apr 2009 14:15:27 -0300
From:	Breno Leitao <leitao@...ux.vnet.ibm.com>
To:	e1000-devel@...ts.sourceforge.net
CC:	netdev <netdev@...r.kernel.org>
Subject: [PATCH net-next] ixgbe: removing unnecesary assignments

This patch removes some assignment that are not necessary. Since the ret
variable is declared as false during its initialization, it makes no sense to
reassign false to it again.

Signed-off-by: Breno Leitao <leitao@...ux.vnet.ibm.com>

---
 drivers/net/ixgbe/ixgbe_main.c |   12 ------------
 1 files changed, 0 insertions(+), 12 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index 5020f11..c238677 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -2775,8 +2775,6 @@ static inline bool ixgbe_set_dcb_queues(struct ixgbe_adapter *adapter)
 		adapter->num_tx_queues =
 		                      adapter->ring_feature[RING_F_DCB].indices;
 		ret = true;
-	} else {
-		ret = false;
 	}
 
 	return ret;
@@ -2802,8 +2800,6 @@ static inline bool ixgbe_set_rss_queues(struct ixgbe_adapter *adapter)
 		adapter->num_tx_queues =
 		                      adapter->ring_feature[RING_F_RSS].indices;
 		ret = true;
-	} else {
-		ret = false;
 	}
 
 	return ret;
@@ -2910,8 +2906,6 @@ static inline bool ixgbe_cache_ring_rss(struct ixgbe_adapter *adapter)
 		for (i = 0; i < adapter->num_tx_queues; i++)
 			adapter->tx_ring[i].reg_idx = i;
 		ret = true;
-	} else {
-		ret = false;
 	}
 
 	return ret;
@@ -2986,14 +2980,8 @@ static inline bool ixgbe_cache_ring_dcb(struct ixgbe_adapter *adapter)
 					adapter->rx_ring[i].reg_idx = i << 5;
 
 				ret = true;
-			} else {
-				ret = false;
 			}
-		} else {
-			ret = false;
 		}
-	} else {
-		ret = false;
 	}
 
 	return ret;
-- 
1.6.0.2

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html