netdev - Re: [Patch 1/1][RFC] NETDEV: Find network bugs by validating the sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090429.145338.149717676.davem@davemloft.net>
Date:	Wed, 29 Apr 2009 14:53:38 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dvomlehn@...co.com
Cc:	netdev@...r.kernel.org
Subject: Re: [Patch 1/1][RFC] NETDEV: Find network bugs by validating the
 sk_buff state

From: David VomLehn <dvomlehn@...co.com>
Date: Wed, 29 Apr 2009 08:14:40 -0700

> On Tue, Apr 28, 2009 at 10:30:58PM -0700, David Miller wrote:
>> 
>> Sorry, for this to be useful distributions are going to turn it on by
>> default, and adding 24 bytes to struct sk_buff on 64-bit when we're
>> trying everything in our power to make it smaller rather than larger
>> is not acceptable.
> 
> That's like saying that any of the kernel debugging options have to be on
> by default.  I expect that most folks won't want this on unless they are
> looking for a bug. 

We don't have networking buffer structure elements that implement
debugging, and it's for a reason.

>> It's a useful change, something to keep in one's back pocket when
>> debugging something, but not for upstream, sorry.
> 
> Right. This is why it depends on KERNEL_DEBUG and why it is off by default.

All of this is moot if distributions decide to start turning this
on, and from my experience they will.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html