netdev - Re: [PATCH] net: skb_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 01 May 2009 10:52:01 +0200
From:	Eric Dumazet <dada1@...mosbay.com>
To:	David Miller <davem@...emloft.net>
CC:	Andrew Dickinson <andrew@...dna.net>, jelaas@...il.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net: skb_tx_hash() improvements

Eric Dumazet a écrit :
> David, here is the followup I promised
> 
> Thanks
> 
> [PATCH] net: skb_tx_hash() improvements
> 
> When skb_rx_queue_recorded() is true, we dont want to use jhash distribution
> as the device driver exactly told us which queue was selected at RX time.
> jhash makes a statistical shuffle, but this wont work with only 8 different inputs.
> 
> We also need to implement a true reciprocal division, to not disturb
> symmetric setups (when number of tx queues matches number of rx queues)
> and cpu affinities.
> 
> This patch introduces a new helper, dev_real_num_tx_queues_set()
> to set both real_num_tx_queues and its reciprocal value,
> and makes all drivers use this helper.

Oh well, this was wrong, I took divide result while we want a modulo !

Need to think a litle bit more :)



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html