netdev - Re: [PATCH] net: Add the FCoE Initialization Protocol ethertype

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090501.155601.205697782.davem@davemloft.net>
Date:	Fri, 01 May 2009 15:56:01 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	robert.w.love@...el.com
Cc:	James.Bottomley@...senPartnership.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: Add the FCoE Initialization Protocol ethertype

From: "Love, Robert W" <robert.w.love@...el.com>
Date: Fri, 1 May 2009 15:53:32 -0700

> The FIP implementation is upstream, in drivers/scsi/libfcoe.c.
> There is a local define in include/scsi/fc/fc_fip.h for ETH_P_FCOE
> and I'd rather move it to the propper location.

Then add that local definition removal to your patch so there is
no mystery about what this is used for.

> I can refresh this patch to include the fc_fip.h removal and you and
> James can decide who takes the patch if that's a better aproach.

That works much better, and to avoid merge issues you can send it
via James with my pre-ack:

Acked-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html