netdev - Re: [RFC PATCH] qos: Limit a filter's priority to a 16 bit value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

[an error occurred while processing this directive]

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1241231732.7162.13.camel@dogo.mojatatu.com>
Date:	Fri, 01 May 2009 22:35:32 -0400
From:	jamal <hadi@...erus.ca>
To:	David Miller <davem@...emloft.net>
Cc:	robert.w.love@...el.com, netdev@...r.kernel.org,
	jeffrey.t.kirsher@...el.com
Subject: Re: [RFC PATCH] qos: Limit a filter's priority to a 16 bit value

On Fri, 2009-05-01 at 19:10 -0700, Love, Robert W wrote:

> I don't want our script to yank out the
> multiq qdisc just because FCoE traffic has stopped. The FCoE
> script doesn't know if the user has other filters applied for
> that interface/qdisc. The script should just remove its
> filters and not disrupt anything else on the chain.

True - but if you specify the prio on add/del you should be fine
though.
I looked at about 15-20 scripts and i noticed i always specified
the priority; i suspect most people do thats why noone bumped into
this over the years.

On Fri, 2009-05-01 at 19:18 -0700, David Miller wrote:

> So could I just get that one-liner fix patch from somebody?

Robert, would you do the honors of submitting the patch since
you did all the hardwork?

> Thanks :-)
> 
> Meanwhile, on the issue of how this value is stored, perhaps someone
> intended to support "classful" filter priorities, just as we support
> classful qdiscs.  Or perhaps someone had the idea to store the
> protocol in there as well, who knows :-)

I cant remember the reason. Alexey probably would - but i think the
important point is it is consistent everywhere.

cheers,
jamal

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html