netdev - RE: [RFC PATCH] qos: Limit a filter's priority to a 16 bit value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1241229126.7162.5.camel@dogo.mojatatu.com>
Date:	Fri, 01 May 2009 21:52:06 -0400
From:	jamal <hadi@...erus.ca>
To:	"Love, Robert W" <robert.w.love@...el.com>
Cc:	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
Subject: RE: [RFC PATCH] qos: Limit a filter's priority to a 16 bit value

On Fri, 2009-05-01 at 16:30 -0700, Love, Robert W wrote:

> I should be more clear by saying that this should only
> fail with filter priorities assigned by the kernel.
> I think if the user passes down the priority when
> creating the filter it should always be 16bits and it's
> fine.
> 
> However, when the kernel is assigning priorities, the
> first assigned priority for a filter is 0xC0000000,
> the second is "the lowest priority - 1" so 0xBFFFFFFF.
> 
> It will assign this value in tcf_auto_prio() which will
> directly assign the 32bit value to to tp->prio with-
> 
> tp->prio = nprio ? : tcf_auto_prio(*back);

I think the above should read:
tp->prio = nprio ? : TC_H_MAJ(tcf_auto_prio(*back));

More importantly however, you should _never_ specify
a filter you intend to delete individually without specifying 
its priority.
Common practise in scripts is to just delete the root 
qdisc or class to delete all filters.

cheers,
jamal

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html