netdev - Re: [PATCH] 3c589_cs: add cis(firmware) of 3Com multifunction pcmcia card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090501.192258.229612946.davem@davemloft.net>
Date:	Fri, 01 May 2009 19:22:58 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ken_kawasaki@...ing.nifty.jp
Cc:	dwmw2@...radead.org, netdev@...r.kernel.org
Subject: Re: [PATCH] 3c589_cs: add cis(firmware) of 3Com multifunction
 pcmcia card

From: Ken Kawasaki <ken_kawasaki@...ing.nifty.jp>
Date: Mon, 27 Apr 2009 21:50:50 +0900

> 
> 3c589_cs,3c574_cs,serial_cs:
> 
>  (1)add cis(firmware) of 3Com lan&modem mulitifunction pcmcia card.
>  (2)load correct configuration register for 3Com card
>  
>  
> Signed-off-by: Ken Kawasaki <ken_kawasaki@...ing.nifty.jp>

Applied to net-next-2.6.

But a few things to be mindful of next time, which I had to
clean up for you.

> + 	}
> +    	link->conf.ConfigBase = parse->config.base;
> +   	link->conf.Present = parse->config.rmask[0];

These three lines started with some spaces, then a tab
character.  It should just be one tab character.

GIT warns about this when applying patches so that such
spacing errors can be caught before code goes into the
tree.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html