netdev - Re: [PATCH] Temporary IPv6 address asignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m1skjlrb79.fsf@fess.ebiederm.org>
Date:	Sun, 03 May 2009 16:58:02 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Lukasz Stelmach <stlman@...zta.fm>
Cc:	David Miller <davem@...emloft.net>, linux-kernel@...r.kernel.org,
	yoshfuji@...ux-ipv6.org, netdev@...r.kernel.org
Subject: Re: [PATCH] Temporary IPv6 address asignment

Lukasz Stelmach <stlman@...zta.fm> writes:

I don't know about the rest of your patch the sysctl hunks are wrong.

> diff --git a/include/linux/sysctl.h b/include/linux/sysctl.h
> index e76d3b2..951ba2c 100644
> --- a/include/linux/sysctl.h
> +++ b/include/linux/sysctl.h
> @@ -570,15 +570,16 @@ enum {
>  	NET_IPV6_TEMP_PREFERED_LFT=13,
>  	NET_IPV6_REGEN_MAX_RETRY=14,
>  	NET_IPV6_MAX_DESYNC_FACTOR=15,
> -	NET_IPV6_MAX_ADDRESSES=16,
> -	NET_IPV6_FORCE_MLD_VERSION=17,
> -	NET_IPV6_ACCEPT_RA_DEFRTR=18,
> -	NET_IPV6_ACCEPT_RA_PINFO=19,
> -	NET_IPV6_ACCEPT_RA_RTR_PREF=20,
> -	NET_IPV6_RTR_PROBE_INTERVAL=21,
> -	NET_IPV6_ACCEPT_RA_RT_INFO_MAX_PLEN=22,
> -	NET_IPV6_PROXY_NDP=23,
> -	NET_IPV6_ACCEPT_SOURCE_ROUTE=25,
> +	NET_IPV6_DESYNC_FACTOR=16,
> +	NET_IPV6_MAX_ADDRESSES=17,
> +	NET_IPV6_FORCE_MLD_VERSION=18,
> +	NET_IPV6_ACCEPT_RA_DEFRTR=19,
> +	NET_IPV6_ACCEPT_RA_PINFO=20,
> +	NET_IPV6_ACCEPT_RA_RTR_PREF=21,
> +	NET_IPV6_RTR_PROBE_INTERVAL=22,
> +	NET_IPV6_ACCEPT_RA_RT_INFO_MAX_PLEN=23,
> +	NET_IPV6_PROXY_NDP=24,
> +	NET_IPV6_ACCEPT_SOURCE_ROUTE=26,
>  	__NET_IPV6_MAX
>  };

These are numbers used in the kernel sysctl binary ABI.  You just
changed them breaking the ABI, when you put NET_IPV6_DESYNC_FACTOR in
the middle.

> @@ -4124,6 +4167,14 @@ static struct addrconf_sysctl_table
>  			.data		=	&ipv6_devconf.max_desync_factor,
>  			.maxlen		=	sizeof(int),
>  			.mode		=	0644,
> +			.proc_handler	=	addrconf_sysctl_desync,
> +		},
> +		{
> +			.ctl_name	=	NET_IPV6_DESYNC_FACTOR,
> +			.procname	=	"desync_factor",
> +			.data		=	&ipv6_devconf.desync_factor,
> +			.maxlen		=	sizeof(int),
> +			.mode		=	0444,
>  			.proc_handler	=	proc_dointvec,
 		},

The sysctl binary abi is currently frozen and deprecated.  Which means
you should set .ctl_name = CTL_UNNUMBERED or simply omit ctl_name on
new sysctl entries.

Eric
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html