[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 04 May 2009 21:31:04 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: jeffrey.t.kirsher@...el.com
Cc: netdev@...r.kernel.org, gospo@...hat.com,
jesse.brandeburg@...el.com
Subject: Re: [net-2.6 PATCH] e1000: fix virtualization bug
From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Mon, 04 May 2009 14:19:42 -0700
> a recent fix to e1000 (commit 15b2bee2) caused KVM/QEMU/VMware based
> virtualized e1000 interfaces to begin failing when resetting.
>
> This is because the driver in a virtual environment doesn't
> get to run instructions *AT ALL* when an interrupt is asserted.
> The interrupt code runs immediately and this recent bug fix
> allows an interrupt to be possible when the interrupt handler
> will reject it (due to the new code), when being called from
> any path in the driver that holds the E1000_RESETTING flag.
>
> the driver should use the __E1000_DOWN flag instead of the
> __E1000_RESETTING flag to prevent interrupt execution
> while reconfiguring the hardware.
>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists