netdev - Re: [PATCH] igb: Record hardware RX overruns in net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 May 2009 11:47:09 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Jesper Dangaard Brouer <hawk@...x.dk>
Cc:	"David S. Miller" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	e1000-devel@...ts.sourceforge.net, jesse.brandeburg@...el.com,
	bruce.w.allan@...el.com, peter.p.waskiewicz.jr@...el.com,
	john.ronciak@...el.com
Subject: Re: [PATCH] igb: Record hardware RX overruns in net_stats

On Mon, May 4, 2009 at 4:06 AM, Jesper Dangaard Brouer <hawk@...x.dk> wrote:
>
> Hardware RX fifo overruns for the 82576 is stored in the
> RNBC (Receive No Buffers Count) register.
>
> I choose the store the RNBC value in net_stats.rx_fifo_errors.
>
> Saving the stats in dev->net_stats makes it visible via
> /proc/net/dev as "fifo", and thus viewable to ifconfig
> as "overruns" and 'netstat -i' as "RX-OVR".
>
> The Receive No Buffers Count (RNBC) can already be queried by
> ethtool -S as "rx_no_buffer_count".
>
> Signed-off-by: Jesper Dangaard Brouer <hawk@...x.dk>
> ---
>

NAK.  RNBC is not a counter for buffer overruns, and so should not be
counted as such.

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html