netdev - Re: [PATCH] bnx2: Fix panic in bnx2_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090506.164736.36849446.davem@davemloft.net>
Date:	Wed, 06 May 2009 16:47:36 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mchan@...adcom.com
Cc:	netdev@...r.kernel.org, pmjdebruijn@...de.nl,
	hnoefer@...onet-ndh.com
Subject: Re: [PATCH] bnx2: Fix panic in bnx2_poll_work().

From: "Michael Chan" <mchan@...adcom.com>
Date: Wed, 6 May 2009 10:23:56 -0700

> Add barrier() to bnx2_get_hw_{tx|rx}_cons() to fix this issue:
> 
> http://bugzilla.kernel.org/show_bug.cgi?id=12698
> 
> This issue was reported by multiple i386 users.  Without barrier(),
> the compiled code looks like the following where %eax contains the
> address of the tx_cons or rx_cons in the DMA status block.  The
> status block contents can change between the cmpb and the movzwl
> instruction.  The driver would crash if the value was not 0xff during
> the cmpb instruction, but changed to 0xff during the movzwl
> instruction.
 ...
> Signed-off-by: Michael Chan <mchan@...adcom.com>

Fair enough, applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html