netdev - Re: [PATCH 3/4] iscsi class, libiscsi: Add net config.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1241628144.10731.41.camel@HP1>
Date:	Wed, 6 May 2009 09:42:24 -0700
From:	"Michael Chan" <mchan@...adcom.com>
To:	"Mike Christie" <michaelc@...wisc.edu>
cc:	"davem@...emloft.net" <davem@...emloft.net>,
	"James.Bottomley@...senPartnership.com" 
	<James.Bottomley@...senPartnership.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"open-iscsi@...glegroups.com" <open-iscsi@...glegroups.com>
Subject: Re: [PATCH 3/4] iscsi class, libiscsi: Add net config.


On Wed, 2009-05-06 at 09:40 -0700, Mike Christie wrote:
> Michael Chan wrote:
> > Add ISCSI_NETLINK messages to get/set vendor specific information.
> > This is to support bnx2i that handles net config of private iSCSI
> > IP address in userspace.
> > 
> > Signed-off-by: Anil Veerabhadrappa <anilgv@...adcom.com>
> > Signed-off-by: Michael Chan <mchan@...adcom.com>
> > Signed-off-by: Mike Christie <michaelc@...wisc.edu>
> > Acked-by: David S. Miller <davem@...emloft.net>
> > ---
> >  drivers/scsi/scsi_transport_iscsi.c |   59 ++++++++++++++++++++++++++++++++++-
> >  include/scsi/iscsi_if.h             |   14 ++++++++
> >  include/scsi/scsi_transport_iscsi.h |    6 +++
> >  3 files changed, 78 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
> > index 0947954..ef3af96 100644
> > --- a/drivers/scsi/scsi_transport_iscsi.c
> > +++ b/drivers/scsi/scsi_transport_iscsi.c
> > @@ -995,6 +995,37 @@ int iscsi_recv_pdu(struct iscsi_cls_conn *conn, struct iscsi_hdr *hdr,
> >  }
> >  EXPORT_SYMBOL_GPL(iscsi_recv_pdu);
> >  
> > +extern int iscsi_vendor_priv_mesg(struct Scsi_Host *shost,
> 
> Just a cut and paste error probably. You have an extern in there.

Thanks for noticing.  Will fix this up in the next version of the patch.

> 
> > +				  struct iscsi_transport *transport,
> > +				  uint16_t priv_op,
> > +				  char *data, uint16_t data_size)
> > +{
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html